On Tue, 8 May 2007 19:39:35 +0200
Andre Poenitz <[EMAIL PROTECTED]> wrote:

> On Mon, May 07, 2007 at 10:14:04PM +0300, Micha Feigin wrote:
> > Ok, I made a patch, hope that it is the correct solution, if so then it's a
> > one liner
> > Didn't know where to send it to
> > 
> > Index: src/insets/InsetBox.cpp
> > ===================================================================
> > --- src/insets/InsetBox.cpp     (revision 18217)
> > +++ src/insets/InsetBox.cpp     (working copy)
> > @@ -344,7 +344,7 @@
> >                         // FIXME UNICODE
> >                         os << '[' <<
> > from_ascii(params_.height.asLatexString()) << ']';
> > -               } else {
> > +               } else if (~params_.height.zero()) {
> 
> Better !params_.height.zero() ?
> 

Yes, I caught that one. The check should also be a bit higher since it misses
an option.

The correct patch I posted before to the devel list is:

Index: src/insets/InsetBox.cpp
===================================================================
--- src/insets/InsetBox.cpp     (revision 18229)
+++ src/insets/InsetBox.cpp     (working copy)
@@ -340,16 +340,18 @@
                        os << "\\begin{minipage}";
 
                os << "[" << params_.pos << "]";
-               if (params_.height_special == "none") {
-                       // FIXME UNICODE
-                       os << '[' << from_ascii(params_.height.asLatexString())
-                          << ']';
-               } else {
-                       // Special heights
-                       // FIXME UNICODE
-                       os << "[" << params_.height.value()
-                          << '\\' << from_utf8(params_.height_special)
-                          << ']';
+               if (!params_.height.zero()) {
+                       if (params_.height_special == "none") {
+                               // FIXME UNICODE
+                               os << '[' << 
from_ascii(params_.height.asLatexString())
+                                  << ']';
+                       } else {
+                               // Special heights
+                               // FIXME UNICODE
+                               os << "[" << params_.height.value()
+                                  << '\\' << from_utf8(params_.height_special)
+                                  << ']';
+                       }
                }
                if (params_.inner_pos != params_.pos)
                        os << "[" << params_.inner_pos << "]";

> Andre'
> 

Reply via email to