[PATCH] Makefile: do not call ar directly

[Hoël Bézier]

Hi!

I’ve now improved support for lzip compression in ./play.it and it awaits approval to be merged, thanks to you. Testing my contribution, I found out that plzip and tarlz are not considered stable on Gentoo, although they are on Debian. This might be because of a “bug” in lzlib, as reported here: https://bugs.gentoo.org/721916 The bug report targets lzlib-1.11, but I’ve been able to reproduce it with lzlib-1.12.

Any comments are welcome,
Hoël

diff --color -u -r lzlib-1.12/configure lzlib-1.12-r1/configure
--- a/configure	2021-01-02 00:35:39.000000000 +0100
+++ b/configure	2021-11-06 20:35:56.404876216 +0100
@@ -29,6 +29,7 @@
 libdir='$(exec_prefix)/lib'
 mandir='$(datarootdir)/man'
 CC=gcc
+AR=ar
 CPPFLAGS=
 CFLAGS='-Wall -W -O2'
 LDFLAGS=
@@ -79,6 +80,7 @@
 		echo "  --enable-shared       build also a shared library [disable]"
 		echo "  --disable-ldconfig    don't run ldconfig after install"
 		echo "  CC=COMPILER           C compiler to use [${CC}]"
+		echo "  AR=LINKER             C archiver to use [${AR}]"
 		echo "  CPPFLAGS=OPTIONS      command line options for the preprocessor [${CPPFLAGS}]"
 		echo "  CFLAGS=OPTIONS        command line options for the C compiler [${CFLAGS}]"
 		echo "  CFLAGS+=OPTIONS       append options to the current value of CFLAGS"
@@ -118,6 +120,7 @@
 	--disable-ldconfig) disable_ldconfig=yes ;;
 
 	CC=*)              CC=${optarg} ;;
+	AR=*)              AR=${optarg} ;;
 	CPPFLAGS=*)  CPPFLAGS=${optarg} ;;
 	CFLAGS=*)      CFLAGS=${optarg} ;;
 	CFLAGS+=*)     CFLAGS="${CFLAGS} ${optarg}" ;;
@@ -189,6 +192,7 @@
 echo "libdir = ${libdir}"
 echo "mandir = ${mandir}"
 echo "CC = ${CC}"
+echo "AR = ${AR}"
 echo "CPPFLAGS = ${CPPFLAGS}"
 echo "CFLAGS = ${CFLAGS}"
 echo "LDFLAGS = ${LDFLAGS}"
@@ -220,6 +224,7 @@
 libdir = ${libdir}
 mandir = ${mandir}
 CC = ${CC}
+AR = ${AR}
 CPPFLAGS = ${CPPFLAGS}
 CFLAGS = ${CFLAGS}
 LDFLAGS = ${LDFLAGS}
diff --color -u -r lzlib-1.12/Makefile.in lzlib-1.12-r1/Makefile.in
--- a/Makefile.in	2020-05-25 00:38:14.000000000 +0200
+++ b/Makefile.in	2021-11-06 20:35:56.494876214 +0100
@@ -1,6 +1,5 @@
 
 DISTNAME = $(pkgname)-$(pkgversion)
-AR = ar
 INSTALL = install
 INSTALL_PROGRAM = $(INSTALL) -m 755
 INSTALL_DATA = $(INSTALL) -m 644

--- a/app-arch/lzlib/lzlib-1.12.ebuild	2021-09-15 04:39:43.000000000 +0200
+++ b/app-arch/lzlib/lzlib-1.12.ebuild	2021-11-06 20:43:48.732862261 +0100
@@ -22,6 +22,7 @@
 		--prefix="${EPREFIX}"/usr
 		--libdir='$(prefix)'/$(get_libdir)
 		CC="$(tc-getCC)"
+		AR="$(tc-getAR)"
 		CFLAGS="${CFLAGS}"
 		CPPFLAGS="${CPPFLAGS}"
 		LDFLAGS="${LDFLAGS}"

The issue is lzlib Makefile calls ar directly, instead of using the AR variable. This is undesirable on Gentoo to prevent issues while cross-compiling, for example. I’ve seen that the Makefile handles CC correctly however, so all one needs to do is to write some similar instructions for AR. Since this does not seem too hard to fix, I figured I would do it myself. So I’ve attached the patch I wrote. I’ve tested this, and this seems to do the trick. Of course, the ebuild used to compile the library on Gentoo also needs to be patched, and if I’m not mistaken, you’re the maintainer, so I’ve attached my patch to the ebuild as well. If you’re not, well tell me and I’ll open an issue on Gentoo bugtracker myself. :)

signature.asc
Description: PGP signature