Erwan, First I would like to thank you for your interest in MAAS and getting it to work with VirtualBox. We would be interested in accepting this patch, but our development process requires some steps on your part to get this landed.
1. A launchpad account. The core MAAS project is developed at http://launchpad.net/maas. If you already have a launchpad account then great, if not please create one at https://launchpad.net/+login. 2. Signed contributes agreement. The Canonical contributes agreement must be signed before we can accept your merge request. So go ahead and agree to this before going forward. https://www.ubuntu.com/legal/contributors/submit 3. A bazaar branch. Currently MAAS is developed with bazaar. So you will want to pull the MAAS source code and make your changes locally in the branch and then push the changes to launchpad. $ sudo apt update && sudo apt install bzr $ bzr launchpad-login $ bzr branch lp:maas $ cd maas ... apply your patches ... $ bzr commit -m "Add virtual box power driver." $ bzr push lp:~{your-launchpad-username}/maas/add-vbox-driver 4. Propose the branch. Once you have pushed the branch then you can propose it to be merged into trunk. $ bzr lp-open Will open a web browser with your new branch. Click the "Propose for merging" button and provide a commit message. Overall the code change looks like a good start. The biggest missing piece is the unit tests for this change. You will need to add unit tests for this new driver. Look at the other drivers for examples on how to unit test this new driver. Looking forward to working with you to get your patches landed in upstream MAAS, and any future patches to MAAS! Thanks, Blake Rouse Technical Lead Software Engineer, MAAS Team Canonical USA On Wed, Apr 19, 2017 at 5:56 PM, Erwan MAS <[email protected]> wrote: > Hi > > Please find in attachement , a patch for maas 2.1 & maas 2.2 . > > Power address : login@(ip|name) > Power ID : name_of_the_virtual_machine > > For using this : > maas user must be allow to ssh to the server and run the command > VBoxManage > > Thanks > > -- > Erwan MAS > > -- > Maas-devel mailing list > [email protected] > Modify settings or unsubscribe at: https://lists.ubuntu.com/ > mailman/listinfo/maas-devel > >
-- Maas-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/maas-devel
