Hi Michael,
I have read your patch, and i will mainly comment your merged version of drawAlphaRect.

Is CGContextSave really unnecessary so that you removed it?

Should RefreshRect be placed before or after EndGraphics?

I ask you and the list these questions because i'm not sure of the answers.

Ismael MERZAQ

Michael Sicotte a écrit :
Ismael,

On Mar 13, 2007, at 4:05 PM, Ismael wrote:

Hi,
Concerning drawAlphaRect, Damien implemented this functions some time ago, but hasn't commited it yet.

...
I propose that you merge your patch with damien's because these 2 patches have both good things and uncompleted parts that are completed by the other patch.

Here's damien patch: http://lebasket.free.fr/OOo/09_03_07/patch03_03_07InvertAlphaRect.diff

Ismael MERZAQ

Thanks for taking the time to look at my patch and comment. Based on Damien's work and your suggestions, I have revised the patch and uploaded it here for those who have time to look at it.

http://www.mikesicotte.com/patch/070313drawAlphaRect_salgdi.cxx.diff


I have also worked on invert for the point array, and I am testing it now. It is not included in the above patch.

Thanks to all who took the time to comment.

Mike



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to