Hi Florian,
Florian Heckl a écrit :
I am not sure if you really corrected this passage the way Herbert
meant. I guess he meant something like
ImplGetSVData()->maNWFData.mbIsScrollbarDoubleMax =
isAppleScrollBarVariantDoubleMax();
in one line instead of 4 lines. (Herbert, correct me if meant something
different!)
Correct me if I'm wrong, but:
getAppleScrollBarVariant(); // Default is DoubleMax
is equivalent, no ? (one line, and more simple )
One other thing I noticed while looking at the following:
+static void getAppleScrollBarVariant(void)
[... cut ... ]
+ if ( !CFStringCompare(ScrollBarVariant, CFSTR("DoubleMax"),
kCFCompareCaseInsensitive) )
+ ImplGetSVData()->maNWFData.mbIsScrollbarDoubleMax = true;
+ else
+ ImplGetSVData()->maNWFData.mbIsScrollbarDoubleMax = false;
+ CFRelease( ScrollBarVariant );
If you allocate a CFStringRef with CFSTR(str), then you have to also
release it.
Ooops, yes, I'll have a look and see how modify that :)
I hope this function is not getting called very often :)
No no, only once :-)
Kind regards,
Eric
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
