Rainer Müller wrote: > Blair Zajac wrote: >> I was thinking that we should have a pre-commit script reject commits >> if a portfile does not increment a revision or version if it changes >> any of its depends_*. I find this pretty annoying to see commits that >> add a dependency that don't bump a version or revision. > > I don't see why changing depends_* should change the revision. Either it > prevented the installation at all or users installed the dependency by > hand before. It doesn't change the files which are going to be > installed. Incrementing the revision would force them to do an > unnecessary recompile. > > The only thing I can think of is that the output of `port dependents' > could be 'wrong'. But that's reflecting the state of the port as it was > installed, so it is kind of correct.
If you have the base port installed, say libfoo, but it's not listed as a dependency, then if you remove it, then you'll unintentionally break any ports that picked up a dependency upon it at configure time. Blair _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev