On Aug 3, 2008, at 08:34, [EMAIL PROTECTED] wrote:
Revision: 38948
http://trac.macosforge.org/projects/macports/changeset/38948
Author: [EMAIL PROTECTED]
Date: 2008-08-03 06:34:32 -0700 (Sun, 03 Aug 2008)
Log Message:
-----------
graphics/dcmtk:
New port, closes #16163.
+variant lib description {Install libraries and include files.} {
+ destroot.target-append install-lib
+}
+
+default_variants +lib
Can this variant be removed? The port takes over 5 minutes to build on a dual-core Intel Mac, and additionally building the libraries only takes a few additional seconds.
Was disk space the reason the variant was created? I will grant that the installed port occupies 52MiB of disk space without libraries vs. 67MiB with. But disk space is cheap these days. I think most people won't miss the additional 15MiB.
The reason I bring it up in the first place is that MacPorts doesn't support negative variants fully, in that they are not remembered after the install is done. If someone really didn't want the libraries, they would "sudo port install dcmtk -lib", however the next time they "sudo port upgrade dcmtk" MacPorts will automatically add back in the +lib variant because of the default_variants statement and the fact that it is not recorded anywhere that the user requested to omit the lib variant initially.
If the variant is to be kept, it should be changed to a no_lib variant, as in the attached patch dcmtk-no_lib.diff. However I recommend removing the variant, as in the attached patch dcmtk- always_lib.diff
dcmtk-no_lib.diff
Description: Binary data
dcmtk-always_lib.diff
Description: Binary data
_______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
