On Dec 10, 2008, at 14:19, [EMAIL PROTECTED] wrote:
@@ -40,9 +40,15 @@
reinplace "s|/usr/local/|/opt/local/|g" \
${worksrcpath}/weathermap \
${worksrcpath}/weathermap-cacti-rebuild.php
+
+# Set perl location
+ reinplace "s|/usr/bin/perl|/opt/local/bin/perl|g" \
+ ${worksrcpath}/random-bits/auto-overlib.pl
}
This perl location change seems unrelated,
That change should have been in the commit comments too, but I
forgot. Or
are you saying the reinplace should have been in a separate commit
from
the file delete one?
I was just saying since you didn't mention it in the commit message I
wasn't sure if you meant to commit that change as well.
and also not correct since
you're hard-coding /opt/local instead of using ${prefix}.
Actually the port already hardcodes /opt/local in another reinplace
above, so that needs to be fixed too.
I must have been caffeine deprived. I fixed those in r43416.
Thanks for
catching that.
Hehe!
You also
need a runtime dependency on path:bin/perl:perl5 then.
The rrdtool port depends on perl, so I didn't think it necessary to
repeat
it. Though sometimes I do anyway in these cases. Not sure what
the rule
is, or the best practice either. If you think the perl one should be
there anyway I can add it.
I think since network-weathermap itself uses perl, it should itself
declare a dependency on perl.
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
