On Dec 14, 2008, at 21:18, [email protected] wrote:

Revision: 43783
          http://trac.macports.org/changeset/43783
Author:   [email protected]
Date:     2008-12-14 19:18:43 -0800 (Sun, 14 Dec 2008)
Log Message:
-----------
port1.0/portconfigure.tcl:
Add correct dependencies for the different tools which can
be selected with use_*. Inspired by r43782.


Revision: 43784
          http://trac.macports.org/changeset/43784
Author:   [email protected]
Date:     2008-12-14 19:27:48 -0800 (Sun, 14 Dec 2008)
Log Message:
-----------
port1.0/portconfigure.tcl:
autoreconf is actually provided by autoconf


Revision: 43785
          http://trac.macports.org/changeset/43785
Author:   [email protected]
Date:     2008-12-14 19:35:03 -0800 (Sun, 14 Dec 2008)
Log Message:
-----------
More appropriate binaries for autoconf & automake deps


option_proc use_autoreconf  set_configure_type
option_proc use_automake    set_configure_type
option_proc use_autoconf    set_configure_type
option_proc use_xmkmf       set_configure_type

proc set_configure_type {option action args} {
    if {[string equal ${action} "set"] && [tbool args]} {
        switch $option {
            use_autoreconf {
                depends_build-append bin:autoreconf:autoconf
            }
            use_automake {
                depends_build-append bin:automake:automake
            }
            use_autoconf {
                depends_build-append bin:autoconf:autoconf
            }
            use_xmkmf {
                depends_build-append bin:xmkmf:imake
            }
        }
    }
}



While I like this in general, how this will interact with ports like the php5 port that override the command? php5 does this:

depends_build \
    port:pkgconfig \
    port:autoconf213

[snip]

use_autoconf            yes
autoconf.cmd            ${prefix}/bin/autoconf213

So now due to the above change a dependency on autoconf gets added even though php5 won't be using a binary called autoconf.

I guess the unnecessary autoconf port won't actually be installed because MacPorts will find the autoconf in /usr/bin to satisfy it... Hmm...


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to