On Feb 14, 2012, at 09:02, [email protected] wrote:
> Revision: 89903
> http://trac.macports.org/changeset/89903
> Author: [email protected]
> Date: 2012-02-14 07:02:20 -0800 (Tue, 14 Feb 2012)
> Log Message:
> -----------
> new port lua-cgilua
> Added: trunk/dports/devel/lua-cgilua/Portfile
> +github.setup keplerproject cgilua 5.1.4
> +github.tarball_from downloads
> +
> +name lua-${github.project}
> +version 5.1.3
There's a mismatch here in the version. Is this version 5.1.3 or 5.1.4? Delete
the "version" line and set the "github.setup" line to the correct version
number.
> +use_configure no
> +build {}
No configure phase and no build phase? That's a strong indicator that this port
does not install any architecture-specific files and should therefore say
"supported_archs noarch".
> +post-destroot {
> + xinstall -m 755 -d ${destroot}${prefix}/bin
No need to create ${destroot}${prefix}/bin; MacPorts automatically creates all
of the mtree inside the destroot for you before it runs the destroot phase.
> + # set module files readonly
> + system -W ${destroot}${prefix}/share/lua/5.1 "chmod -x cgilua.lua
> cgilua/*"
No need to use "system" just to change a file's permissions. Use the Tcl
command "file attributes -permissions" for that.
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
