On May 22, 2012, at 11:10, m...@macports.org wrote:
> Revision: 93430
> https://trac.macports.org/changeset/93430
> Author: m...@macports.org
> Date: 2012-05-22 09:10:00 -0700 (Tue, 22 May 2012)
> Log Message:
> -----------
> xskat: fix build, add md5 checksum
>
> Modified Paths:
> --------------
> trunk/dports/games/xskat/Portfile
>
> Modified: trunk/dports/games/xskat/Portfile
> ===================================================================
> --- trunk/dports/games/xskat/Portfile 2012-05-22 16:03:43 UTC (rev 93429)
> +++ trunk/dports/games/xskat/Portfile 2012-05-22 16:10:00 UTC (rev 93430)
> @@ -13,11 +13,23 @@
> long_description ${description}
> homepage http://www.xskat.de/
> master_sites http://www.xskat.de/
> -checksums sha1 b90859742b62369273d2683bd69006713e1e214d
> +checksums md5 6744cea48a890771736b75083e7ea2b5 \
> + sha1 b90859742b62369273d2683bd69006713e1e214d
We're not particularly fond of md5 anymore. It is a broken algorithm. We want
to use rmd160 and sha256 checksums from now on.
> depends_lib port:xorg-libX11
> -depends_build path:bin/xmkmf:imake \
> - port:gccmakedep
>
> -destroot.target-append install.man
> -destroot.destdir-append BINDIR=${prefix}/bin MANPATH=${prefix}/share/man
> +use_configure no
Why stop using gccmakedep and imake? Is it because you noticed gccmakedep is
completely broken? That's what I noticed anyway. I filed a ticket:
https://trac.macports.org/ticket/34579
> +build.args CFLAGS="${configure.cflags}" CC="${configure.cc}"
> LDFLAGS="${configure.ldflags} -lX11"
> +build.target xskat
You need to arrange to use the correct -arch flags too. The
[get_canonical_archflags] procedure is helpful for this. Add a universal
variant too if you can.
> +destroot {
> + xinstall -m 755 -d ${destroot}${prefix}/bin \
> + ${destroot}${prefix}/share/doc/${name} \
> + ${destroot}${prefix}/share/man/man6
> + xinstall -m 755 ${worksrcpath}/xskat ${destroot}${prefix}/bin/
> + xinstall -m 644 -W ${worksrcpath} CHANGES CHANGES-de INSTALL INSTALL-de \
> + README README-de README.IRC README.IRC-de \
> + ${destroot}${prefix}/share/doc/${name}
> + xinstall ${worksrcpath}/xskat.man
> ${destroot}${prefix}/share/man/man6/xskat.6
> +}
There's no need to xinstall -d directories like ${destroot}${prefix}/bin or
${destroot}${prefix}/share/man/man6 that MacPorts already creates for you
before running the destroot phase.
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
