On Jan 16, 2013, at 20:31, Sean Farley wrote:
> On Wed, Jan 16, 2013 at 7:25 PM, Ryan Schmidt wrote:
>
>> Ok, how's this: there could be a new portgroup option github.livecheck_type
>> which would default to "commits" if github.version matches ^[0-9a-f]{9,}$
>> and github.tag_prefix is empty, or "tags" otherwise. And livecheck.url and
>> livecheck.regex would be set based on github.livecheck_type. So the default
>> github.livecheck_type would suit most uses, and could still be overridden if
>> necessary.
>
> Sounds good. Though, with the regex you have listed any committish of
> length 9 or more would work, so should the portfile check that length
> during setup?
I would say that anytime you want to know whether github.version is a commitish
or a version number, you would use the regex "^[0-9a-f]{9,}$"; no need to
separately check the length since the regex already does that.
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev
