On Nov 23, 2013, at 10:39, [email protected] wrote:
> Revision
> 113780
> Author
> [email protected]
> Date
> 2013-11-23 08:39:52 -0800 (Sat, 23 Nov 2013)
> Log Message
>
> atlas: fix regex in post build
> Modified Paths
>
> • trunk/dports/math/atlas/Portfile
> Diff
>
> Modified: trunk/dports/math/atlas/Portfile (113779 => 113780)
>
> --- trunk/dports/math/atlas/Portfile 2013-11-23 16:39:48 UTC (rev 113779)
> +++ trunk/dports/math/atlas/Portfile 2013-11-23 16:39:52 UTC (rev 113780)
>
> @@ -765,7 +765,7 @@
>
> set libdir ${build.dir}/lib
>
> reinplace "s|^LIBTOOL=.*$|LIBTOOL=\$\(GCC\) \$\(GCCFLAGS\)|" \
>
> ${libdir}/Makefile
>
> - reinplace "s|-dynamic|-dynamiclib|g" ${libdir}/Makefile
>
> + reinplace "s|-dynamic.* |-dynamiclib |g" ${libdir}/Makefile
>
>
This change doesn’t seem right to me. Now, instead of changing e.g.
cd $(tmpd) ; $(LIBTOOL) -dynamic -o ../libsatlas.dylib \
to
cd $(tmpd) ; $(LIBTOOL) -dynamiclib -o ../libsatlas.dylib \
you’ll be changing it to
cd $(tmpd) ; $(LIBTOOL) -dynamiclib \
What problem are you fixing here? Note that this port is not openmaintainer.
I really wish this section of code were not duplicated in the portfile, once
for universal, once for non-universal. Vince, can you consolidate that? If you
need help let me know.
I also don’t see why we have to reinplace the Makefiles in post-build for each
arch. Why not patch makes/Make.lib with a normal patch beforehand?
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
