On Nov 29, 2013, at 9:06 , Ryan Schmidt <ryandes...@macports.org> wrote:
>
> On Nov 28, 2013, at 18:06, mo...@macports.org wrote:
>
>> +# $Id$
>> +
>> +PortSystem 1.0
>> +PortGroup python 1.0
>> +PortGroup github 1.0
>> +
>> +github.setup SciTools cartopy 0.9.0 v
>> +
>> +name py-cartopy
>> +version 0.9.0
>> +categories-append science gis graphics
>> +platforms darwin
>> +
>> +maintainers bo.ingv.it:peter.danecek openmaintainer
>> +
>> +license LGPL3
>
> Needs to be “LGPL-3” (or “LGPL-3+” if later versions are allowed).
>
>> +if {${subport} != ${name}} {
>
> Remember to use eq and ne for string comparisons instead of == and !=.
>
Thanks for catching this!
These are mistakes I should now by now. Il provide a patch.
>> + depends_build-append port:py${python.version}-setuptools \
>> + port:py${python.version}-cython \
>> + port:py${python.version}-numpy
>> +
>> + depends_lib-append port:proj \
>> + port:geos
>> +
>> + depends_run-append port:py${python.version}-numpy \
>> + port:py${python.version}-scipy \
>> + port:py${python.version}-matplotlib \
>> + port:py${python.version}-shapely \
>> + port:py${python.version}-pyshp
>> +
>> + # testing only
>> + depends_run-append port:py${python.version}-nose \
>> + port:py${python.version}-pep8 \
>> + port:py${python.version}-mock \
>> + port:py${python.version}-pil
>> +}
>
> How do you mean, “testing only”? If you mean the test phase, as in “sudo port
> test”, this port doesn’t enable the test phase, and even if it did, runtime
> dependencies aren’t guaranteed to have been installed by the time the test
> phase runs.
No testing is not done during build or installation. So these dependencies are
strictly not necessary. However, when you would like to test the package (after
installation) you would need them. I discussed this on the list, and was
advised to install them as well, because the are small.
So I did, but marked this explicitly, should the comment be reworded?
~petr
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
