Hi Ryan, Why is using a patchfile instead of reinplace preferable?
David On Sun, Jun 8, 2014 at 3:33 PM, Ryan Schmidt <ryandes...@macports.org> wrote: > On Jun 5, 2014, at 12:30 PM, m...@macports.org wrote: > > > Revision > > 120684 > > Author > > m...@macports.org > > Date > > 2014-06-05 10:30:25 -0700 (Thu, 05 Jun 2014) > > Log Message > > > > srecord: Update to version 1.63. (#43916) > > Modified Paths > > > > • trunk/dports/devel/srecord/Portfile > > > @@ -30,8 +30,17 @@ > > > > offsets, split and unsplit for memory striping > schemes. > > > > homepage http://srecord.sourceforge.net/ > > master_sites sourceforge > > > > -checksums md5 8fce124d47f23b4aa187c3b8eebc9fd7 > > > > +checksums rmd160 668d5dc75960666a7c99509f39ecd2602891c384 \ > > + sha256 > 78fec76d04424506e319f59b19a520428a7449ed087a67e1779fa2996992bf1a > > +depends_build port:libtool > > > > configure.cflags-append "-I${prefix}/include" > > > > -configure.args --mandir=${destroot}${prefix}/share/man > > > > +configure.env-append "LIBTOOL=glibtool" > > Consider specifying the absolute path to glibtool i.e. > ${prefix}/bin/glibtool, just in case the user has an unusual binpath > configured. > > > > destroot.destdir prefix=${destroot}${prefix} > > > > > > > > +pre-configure { > > + reinplace {s|@bindir@|$(prefix)/bin|} ${worksrcpath}/Makefile.in > > + reinplace {s|@mandir@|$(prefix)/share/man|} > ${worksrcpath}/Makefile.in > > + reinplace {s|@datarootdir@|$(prefix)/share|} > ${worksrcpath}/Makefile.in > > + reinplace {s|@libdir@|$(prefix)/lib|} ${worksrcpath}/Makefile.in > > + reinplace {s|@includedir@|$(prefix)/include|} > ${worksrcpath}/Makefile.in > > +} > > Could this be done as a normal patchfile instead? I notice you're using > parentheses e.g. "$(prefix)" which is Makefile variable expansion syntax, > not curly brackets e.g. "${prefix}" which would be the Tcl variable > expansion syntax, so no variable substitution is happening here at > reinplace time anyway. > > _______________________________________________ > macports-dev mailing list > macports-dev@lists.macosforge.org > https://lists.macosforge.org/mailman/listinfo/macports-dev >
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
