> On Mar 3, 2015, at 4:54 AM, [email protected] wrote:
>
> Revision
> 133494
> Author
> [email protected]
> Date
> 2015-03-03 02:54:37 -0800 (Tue, 03 Mar 2015)
> Log Message
>
> trunk/dports/sysutils/pypi2port: Corrected python.version to
> python.default_version for python app
It looks like you also made whitespace changes to the whole file. If you make
whitespace changes, you should make a separate commit with only whitespace
changes. That way, such commits can be more easily ignored, and functional
changes can be more easily seen and reviewed.
In this case, the whitespace changes that you made don't appear to be correct.
The modeline states that indents in this file shall occur at multiples of 4
spaces. This is the MacPorts standard style, and the file was following this
style before your changes, but is not now. The whitespace changes should
probably be reverted.
> Modified Paths
>
> • trunk/dports/sysutils/pypi2port/Portfile
> Diff
>
> Modified: trunk/dports/sysutils/pypi2port/Portfile (133493 => 133494)
> --- trunk/dports/sysutils/pypi2port/Portfile 2015-03-03 07:36:08 UTC (rev
> 133493)
> +++ trunk/dports/sysutils/pypi2port/Portfile 2015-03-03 10:54:37 UTC (rev
> 133494)
> @@ -1,45 +1,48 @@
> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil;
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> # $Id$
>
> -PortSystem 1.0
> -PortGroup python 1.0
> +PortSystem 1.0
> +PortGroup python 1.0
>
> -name pypi2port
> -version 133341
> -svn.revision ${version}
> -categories sysutils macports
> -platforms darwin
> -maintainers gaurav openmaintainer
> -license BSD
> -supported_archs noarch
> +name pypi2port
> +version 133341
> +svn.revision ${version}
> +categories sysutils macports
> +platforms darwin
> +maintainers gaurav openmaintainer
> +license BSD
> +supported_archs noarch
>
> -description A python script to generate MacPorts Portfiles
> -long_description ${description} from pypi
> -homepage https://trac.macports.org/wiki/howto/${name}
> +description A python script to generate MacPorts Portfiles
> +long_description ${description} from pypi
> +homepage https://trac.macports.org/wiki/howto/${name}
>
> -fetch.type svn
> -svn.url
> https://svn.macports.org/repository/macports/contrib/${name}
> +fetch.type svn
> +svn.url
> https://svn.macports.org/repository/macports/contrib/${name}
>
> -python.versions 27 34
> +python.default_version 27
>
> +variant python34 conflicts python27 description {Use Python 3.4} {
> + python.default_version 34
> +}
> +
> # list dependencies
> -depends_run-append port:py${python.version}-requests
> +depends_run-append port:py${python.version}-requests
>
> -worksrcdir ${name}
> +worksrcdir ${name}
>
> build {}
>
> post-patch {
> - reinplace "s|#!/usr/bin/env python|#!${python.bin}|"
> ${worksrcpath}/${name}.py
> + reinplace "s|#!/usr/bin/env python|#!${python.bin}|"
> ${worksrcpath}/${name}.py
> }
>
> destroot {
> - xinstall -m 755 ${worksrcpath}/${name}.py
> ${destroot}${prefix}/bin/${name}
> - xinstall -d ${destroot}${prefix}/share/doc/${name}
> - xinstall -m 644 ${worksrcpath}/README.txt
> ${destroot}${prefix}/share/doc/${name}/README.txt
> + xinstall -m 755 ${worksrcpath}/${name}.py ${destroot}${prefix}/bin/${name}
> + xinstall -d ${destroot}${prefix}/share/doc/${name}
> + xinstall -m 644 ${worksrcpath}/README.txt
> ${destroot}${prefix}/share/doc/${name}/README.txt
> }
>
> -# TODO: check the latest svn revision of the file
> # Checks for latest revision in the commit log
> livecheck.type regex
> livecheck.url http://trac.macports.org/log/contrib/pypi2port
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
