Thanks for reviewing. Fixed in r133528.
Cheers! Frank On Mar 3, 2015, at 6:14 PM, Ryan Schmidt <[email protected]> wrote: > >> On Mar 3, 2015, at 5:05 PM, [email protected] wrote: >> >> Revision >> 133521 >> Author >> [email protected] >> Date >> 2015-03-03 15:05:17 -0800 (Tue, 03 Mar 2015) >> Log Message >> >> gecode: Update to version 4.3.3. Change to new maintainer. Add qt4 and qt4 >> variants. (#46941) >> Modified Paths >> >> • trunk/dports/devel/gecode/Portfile > >> -variant qt description {Add QT support} { >> - depends_lib-append port:qt4-mac >> +variant qt conflicts qt5 description {Add QT support} { >> + depends_lib-append port:qt4-mac >> + configure.args-delete --disable-qt >> + configure.args-append --enable-qt >> +} >> + >> +variant qt4 conflicts qt5 description {Add QT support} { >> + depends_lib-append port:qt4-mac >> + configure.args-delete --disable-qt >> + configure.args-append --enable-qt >> +} >> + >> +variant qt5 description {Add QT5 support} { >> + depends_lib-append port:qt5-mac >> configure.args-delete --disable-qt >> configure.args-append --enable-qt >> } > > The qt and qt4 variants appear to do the same thing... the qt variant should > probably be marked as a legacy compatibility variant that does nothing but > requires the qt4 variant. > > Consider using configure.args-replace instead of using configure.args-delete > and configure.args-append. > > The qt5 variant should be marked as conflicting with the qt4 variant. > > The description of the qt4 variant should mention the version 4, just as the > qt5 variant mentions the version 5. > > _______________________________________________ macports-dev mailing list [email protected] https://lists.macosforge.org/mailman/listinfo/macports-dev
