On Mar 10, 2015, at 11:43 AM, Andrea D'Amore <and.dam...@macports.org> wrote:
> On 10 March 2015 at 13:50, Ryan Schmidt <ryandes...@macports.org> wrote: >> For future reference, since this does not change the way that the port >> installs by default, the revision should not have been increased. > > I stood by the rule to bump revision if installed files changed, > regardless if the change affected default install or not. > This actually makes more sense, duly noted. It's not actually about default anything. You revbump when your change will affect any existing installs. A commit that changes files that are only installed under a variant still merits a revbump. Your change did not merit a revbump because it could not have affected any existing libxml2 installs. The `readline` variant did not exist before. No existing user will see any difference when they upgrade to libxml @2.9.2_2. vq _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
