On Jun 6, 2015, at 6:05 PM, David Evans wrote:

> On 6/5/15 11:28 PM, Ryan Schmidt wrote:
>>> On Jun 6, 2015, at 12:39 AM, [email protected] wrote:
>>> 
>>> Revision
>>> 137202
>>> Author
>>> [email protected]
>>> Date
>>> 2015-06-05 22:39:05 -0700 (Fri, 05 Jun 2015)
>>> Log Message
>>> 
>>> tidyp: add livecheck.
>>> Modified Paths
>>> 
>>>     • trunk/dports/www/tidyp/Portfile
>>> Diff
>>> 
>>> Modified: trunk/dports/www/tidyp/Portfile (137201 => 137202)
>>> +livecheck.type      regex
>>> +livecheck.url       https://github.com/petdance/tidyp/downloads
>>> +livecheck.regex     "${name}-(\\d+(?:\\.\\d+)*)${extract.suffix}"
>> Please consider using the github portgroup. It would save you from having to 
>> implement this stuff yourself.
>> 
>> 
> I tried but it doesn't work with this particular port without a lot of extra 
> effort/massaging.
> 
> Snapshots from github for this port are incomplete and unbuildable and so one 
> needs to use the tarball specifically prepared to build correctly by the 
> upstream developers from their (slightly non-standard) download directory.  
> (All this is mentioned in their install documentation).
> 
> I took the easier path (pun intended). :-)

Actually there's nothing unusual about tidyp. It just uses the now-discontinued 
github "downloads" service, but the github portgroup still accommodates this, 
as explained in the github portgroup's documentation, which is in comments in 
the github portgroup file: 
https://trac.macports.org/browser/trunk/dports/_resources/port1.0/group/github-1.0.tcl

As far as I know, the github portgroup accommodates all permutations of 
downloading from the github service*, so it should be used in all ports whose 
software is hosted at github, as this consolidates knowledge about github URLs 
and behaviors in a single location, so that if the github service changes their 
site structure in the future, it can be fixed in a single place, rather than 
having to touch a bunch of different portfiles.

I've committed the changes to the port: 
http://trac.macports.org/changeset/137227


* with the exception of archive URLs which as far as I can tell are not 
strictly speaking needed since they serve the same purpose as the older tarball 
URLs which the github portgroup does support: 
https://trac.macports.org/ticket/40518

_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to