On 6/7/15 12:27 AM, Ryan Schmidt wrote:
On Jun 6, 2015, at 6:27 PM, David Evans wrote:
On 6/5/15 2:27 PM, Ryan Schmidt wrote:
On Jun 5, 2015, at 4:14 PM, [email protected] wrote:
Revision
137164
Author
[email protected]
Date
2015-06-05 14:14:18 -0700 (Fri, 05 Jun 2015)
Log Message
psh: update to version 1.8.1, new homepage, master_sites.
Modified: trunk/dports/shells/psh/Portfile (137163 => 137164)
+master_sites https://github.com/gnp/psh/archive/
+worksrcdir psh-psh-${version}
Please consider using the github portgroup instead.
Just doing a quick update of an old nomaintainer port. Feel free to embellish
as you see fit.
I just wanted to make sure you were aware of the github portgroup and its
capabilities. It's important to use existing portgroup, rather than try to
reproduce their behavior manually.
Yes, I am aware of the github portgroup. See ffmpeg-devel for an
example. I am also aware of your opinion that it is important to use
existing portgroups in all cases.
But in this case, I now wonder why you're fetching from github, instead of from
cpan.
Because the port's home page indicates that the source should be
downloaded from github (instead of sourceforge) with no mention of
CPAN. Before my modifications the port downloaded from sourceforge so I
followed suit and changed to the github download path instead. I
considered using the github portgroup but decided that doing so to set
the download path only would add undue complexity and would possibly
conflict with the workings of the perl5 portgroup.
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
