Hi Ryan, On Sat, Jan 16, 2016 at 09:25:15AM -0600, Ryan Schmidt wrote: > Instead of overriding the fetch, checksum and extract phases, you > should declare that the port has no distfiles, by writing on a line by > itself: > > distfiles > > With no distfiles, the master_sites line isn't needed either. ("port > lint" will complain about missing master_sites, but that's a bug in > "port lint".) > > > +test {} > > The test phase is disabled by default. There is no need to override it > with an empty block.
[...] > Why construct this file in the build phase? Why not just put the real > file in the files directory and copy it from there? Wouldn't that be > much more straightforward? I've fixed these comments in https://trac.macports.org/changeset/144734. > The whitespace of this portfile does not conform to what the modeline > says the whitespace is. (Indents should be at multiples of 4 spaces, > not 2.) Formatted to conform to the modeline in https://trac.macports.org/changeset/144735. -- Clemens _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev