> On Oct 4, 2016, at 3:58 PM, Rainer Müller <rai...@macports.org> wrote: > > On 2016-10-04 22:03, lar...@macports.org wrote: >> Revision: 153574 >> https://trac.macports.org/changeset/153574 >> Author: lar...@macports.org >> Date: 2016-10-04 13:03:08 -0700 (Tue, 04 Oct 2016) >> Log Message: >> ----------- >> skey: Rename patch >> >> Modified Paths: >> -------------- >> trunk/dports/sysutils/skey/Portfile >> >> Added Paths: >> ----------- >> trunk/dports/sysutils/skey/files/install-skeyprune.8.patch >> >> Removed Paths: >> ------------- >> trunk/dports/sysutils/skey/files/patch-Makefile.in.diff >> >> Modified: trunk/dports/sysutils/skey/Portfile >> =================================================================== >> --- trunk/dports/sysutils/skey/Portfile 2016-10-04 20:00:00 UTC (rev >> 153573) >> +++ trunk/dports/sysutils/skey/Portfile 2016-10-04 20:03:08 UTC (rev >> 153574) >> @@ -25,6 +25,6 @@ >> sha1 d55fb286098900cdf3eb6b174a720a06c722312a \ >> rmd160 33d97cbcd6dbc91bdca5b27056d51d1f5d06b68d >> >> -patchfiles patch-Makefile.in.diff >> +patchfiles install-skeyprune.8.patch >> >> configure.args --mandir=${prefix}/share/man > > Patches should follow the patch-*.diff naming scheme, so this should be > named patch-skeyprune-man8.diff or similar. > > https://guide.macports.org/#development.patches.source
Popular opinion seems to be that we should relax that restriction. I think it's reasonable if we change it to "patch-*.diff or *.patch". My primary gripe was with the way patches used to be named "patch-foo" or "patch-foo.c" which caused editors to use incorrect syntax highlighting. As long as we use a .diff or .patch extension, to indicate to a syntax highlighter that this is a diff or patch file, that should be fine. _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev