> On Sep 27, 2017, at 08:13, Leonardo Brondani Schenkel <leona...@schenkel.net> 
> wrote:
> 
> Zero King (l2dy) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/4d93c582d25ea637a6e1b0eb24cb07fadeed99a5
> 
> commit 4d93c582d25ea637a6e1b0eb24cb07fadeed99a5
> 
> Author: Leonardo Brondani Schenkel <leona...@schenkel.net>
> AuthorDate: Sun Sep 24 21:56:31 2017 +0200
> 
> 
>     dict: update to 1.12.1 (and take maintainership)


> +master_sites        sourceforge

Most projects on SourceForge organize their files in folders. If dict is such a 
project, then you should specify here which folder the file is in, to avoid 
redirects. See https://trac.macports.org/wiki/howto/AvoidRedirects


> +depends_build       port:bison port:flex port:grep port:libtool
> +depends_lib         port:libmaa port:zlib
> +configure.env       LIBTOOL=glibtool

Assuming LIBTOOL is the file to be run, it should be the absolute path 
(${prefix}/bin/glibtool).


> +post-destroot {
> +    xinstall ${filespath}/dict.conf ${destroot}${prefix}/etc
>  }

The default mode for xinstall is 0755, i.e. executable. Conf files should not 
be executable, so you should specify mode 0644 (-m 0644).

Moreover, users are expected to edit conf files, but by installing the file in 
this way, it is registered to the port, which means any user customizations 
will be lost if the port is deactivated or upgraded. Instead, you should 
install a sample conf file, and print instructions telling the user how to copy 
that sample conf file to the real one. See 
https://trac.macports.org/wiki/PortfileRecipes#configfiles


Reply via email to