will look into these. thanks
> On Dec 9, 2017, at 7:59 AM, Ryan Schmidt <ryandes...@macports.org> wrote: > > >> On Dec 8, 2017, at 18:03, Ken wrote: >> >> Ken (kencu) pushed a commit to branch master >> in repository macports-ports. >> >> >> https://github.com/macports/macports-ports/commit/1be703755e82b668905993ab9acb16d854b713b5 >> >> The following commit(s) were added to refs/heads/master by this push: >> >> new 1be7037 irrlicht: new port > >> --- /dev/null >> +++ b/devel/irrlicht/Portfile >> @@ -0,0 +1,50 @@ >> > > >> +master_sites https://downloads.sourceforge.net/irrlicht/ > > You should use the sourceforge fetch group for this. > > set branch [join [lrange [split ${version} .] 0 1] .] > master_sites > sourceforge:project/irrlicht/Irrlicht%20SDK/${branch}/${version}/ > > >> +# patch out test to exclude older zlib versions that fails on some mac >> systems like 10.6 >> +patchfiles-append patch-pngpriv-zlib-test.diff > > If this fails on old systems, it makes me think it's using the system's old > version of zlib, instead of the MacPorts version of zlib that it should be > using. This may need further investigation to correct. > > >> + set flist [glob ${worksrcpath}/include/*.h] >> + foreach f $flist { >> + file copy -force $f >> ${destroot}${prefix}/Library/Frameworks/IrrFramework.framework/Versions/A/Headers >> + } > > Note that it's simpler to use the MacPorts alias "copy", which is exactly the > same as "file copy -force". > > You also don't need a foreach loop. You can just: > > copy {*}[glob ${worksrcpath}/include/*.h] > ${destroot}${prefix}/Library/Frameworks/IrrFramework.framework/Versions/A/Headers > >
