On Sun, Apr 8, 2018 at 3:05 PM, Ryan Schmidt <[email protected]> wrote: > > On Apr 8, 2018, at 04:12, Jackson Isaac wrote: > >> Jackson Isaac (JacksonIsaac) pushed a commit to branch master >> in repository macports-ports. >> >> >> https://github.com/macports/macports-ports/commit/65defdc294622caa6e4c44d874286917a1d51ce1 >> >> The following commit(s) were added to refs/heads/master by this push: >> >> new 65defdc aacgain: Update dirname in post-extract phase >> >> 65defdc is described below >> >> >> commit 65defdc294622caa6e4c44d874286917a1d51ce1 >> >> Author: ijackson >> AuthorDate: Sun Apr 8 14:42:19 2018 +0530 >> >> >> aacgain: Update dirname in post-extract phase >> >> Version and tarball name didn't match and >> hence there was an issue while applying patch. >> >> --- >> audio/aacgain/Portfile | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/audio/aacgain/Portfile b/audio/aacgain/Portfile >> index 481b021..bda6c74 100644 >> --- a/audio/aacgain/Portfile >> +++ b/audio/aacgain/Portfile >> @@ -21,6 +21,10 @@ use_bzip2 yes >> checksums sha256 >> 2bb8e27aa8f8434a4861fdbc70adb9cb4b47e1dfe472910d62d6042cb80a2ee1 \ >> rmd160 8f97121f3797cde45f71839dbe14251b74365ccd >> >> +post-extract { >> + file rename ${workpath}/${name}-1.8 ${workpath}/${name}-${version} >> +} > > Set worksrcdir instead of this. > > However, don't do that, because this update was completely wrong. No version > 1.9 exists at the download site. Take a look: > > http://aacgain.altosdesign.com/alvarez/ > > There is only 1.8. Their web server is just configured in an improperly > helpful manner: If you request the file for the nonexistent 1.9, it silently > redirects you to the file for 1.8: > > $ curl -I http://aacgain.altosdesign.com/alvarez/aacgain-1.9.tar.bz2 > HTTP/1.1 301 Moved Permanently > Content-Type: text/html; charset=iso-8859-1 > Connection: keep-alive > Keep-Alive: timeout=15 > Date: Sun, 08 Apr 2018 09:26:54 GMT > Server: Apache > Location: http://aacgain.altosdesign.com/alvarez/aacgain-1.8.tar.bz2 > > What I did not see in your previous commit which updated the port to "1.9", > because you combined whitespace changes with functional ones, is that the > checksums did not change. So what you've called 1.9 here is definitely > unchanged from 1.8. > > The web site claims a version 1.9 exists, but I don't know where it is. If it > can't be found, the changes you made should be reverted to put the port back > at version 1.8. The epoch will have to be increased so that anybody who did > install 1.9 already will be downgraded back to 1.8.
I did find one at "https://github.com/mecke/aacgain"; but I was not so sure if they both are by same author since 'alvarez' was mentioned at http://aacgain.altosdesign.com and on github it was 'mecke'. Also the commit log didn't help much either. Looking at the README, it looks like this might possibly be the 1.9 version. I would like to know what to do in such a scenario. Should I go forward with the github version ? > > It seems that you didn't try to build this before committing it, or you would > have at least seen the patch failure. Please always verify successful > installation of a port on your own system before committing. > > I did notice the patch failure and thought it might be because the patch file was older and then I forgot to build it again with the new patch file. It was a mistake from my side. Have got little rusty since it has been quite some time updating ports. -- Jackson Isaac
