On Saturday October 27 2018 17:52:15 Ryan Schmidt wrote:

>We could re-add it, or maybe change the source command to work how the include 
>command used to work. But I'm not convinced that we should do that. There 
>aren't many reasons why an include file would be useful, and we evidently 
>haven't needed it for the past 8 years. Rainer used it in a few of his ports 
>before it was removed; I don't think any other developers did.

No, I don't think there's much need for that, although I too have done what Ken 
describes (using different "implementation modules" instead of different 
sections in a single file). It's advanced usage, evidently, not needed in most 
situations, and I've stopped doing it because it always leads to error messages 
during de/activate and uninstall operations. Somehow they're never fatal, but I 
suppose that's a brittle situation that could break at any time.

As said, no such issues in the context where I'm using `source` here, and I 
don't mind putting some extra logic in this one Portfile (esp. since a pre- 
block can in principle be put at the very end of the file where it doesn't 
really hinder).

Maybe describe how to achieve this on the Recipes page, along with the other 
sometimes-useful tricks?

R.

PS: Oh, and don't do "conditional" PortGroup including, at least not if that 
PortGroup defines and sets a default variant. That's a great way to break 
behaviour in a way that can be very tricky to figure out. Don't ask me how I 
know :)


Reply via email to