Ken: I wasn’t trying to suggest that anybody failed at anything. The problem may be specific to dav1d...but if it was more general, I wanted to alert others. That’s all; I meant no offence to anyone.
And I could see how this might escape notice since it only affects meson on older OS versions. In the dav1d PR, CI didn’t produce results for the older OS versions. I thought the CI system was just being grumpy. I’m very much a neophyte with the PR process. Github and git still baffle me all too often. Anyway, I have 'port test meson' running on my 10.10 system even though I don’t expect anything. I don’t have a working virtualization system at the moment. Perhaps tomorrow I can get that back up and try the tests on 10.9 and earlier. And try to build dav1d to get better log info. Craig > On Feb 2, 2021, at 6:30 PM, Ken Cunningham <ken.cunningham.web...@gmail.com> > wrote: > > I will try it. > > If I might say — I would expect that anyone submitting a PR has at least > built the software on their local system, and used it enough to be sure it at > least basically works, if not ran the whole test suite. > > SO — meson must have worked properly on at least the system that was used to > submit the PR. > > I will (and do) thoroughly test the PRs and commits I personally do — which > is why the cctools and libmacho and other updates take as long as they do. > > I have been reviewing, looking over the changes, checking to build logs and > checking the installed files on the PRs before I commit them. > > Sometimes, I miss things — out of 150 PRs committed, Ryan and Josh have found > corrections (revbumps, etc) in three or four. So I accept that rate. > > But I do not expect to find massive broken changes submitted as PRs (we have > been seeing some of that at times, hopefully I caught most of it), or > otherwise wholly untested PRs that are thrown up without even a passing local > build. > > That is asking too much of PR reviewers to have absolutely no trust in the PR > submitters. > > Ken > > > > > > >> On Feb 2, 2021, at 2:32 PM, Craig Treleaven <ctrelea...@cogeco.ca> wrote: >> >> Hi: >> >> It might be that the meson update and/or the switch to python39 has broken >> builds on older Mac OS versions. Specifically, I updated dav1d to 0.8.1 and >> it no longer configures successfully on 10.9 and older versions. Upstream >> says that the now-failing configure test (a simple test to see if the >> compiler can create an executable) has not changed. >> >> Am I the only one seeing this? >> >> The meson project doesn’t seem to have a change log and I haven’t waded >> through all of the commits between versions. Is there a test suite with >> meson? Have we checked it? >> >> Tomorrow, I think I’m going to try to bring up some VM’s and see if >> meson-log.txt has anything interesting on a failing OS version. >> >> Craig >
