cgx.h already had a call to extUtil.h, so I replaced it in parser.c. Build
completed without further errors.
Thanks,
Mark
> On Jul 28, 2022, at 11:22 AM, Chris Jones <jon...@hep.phy.cam.ac.uk> wrote:
>
>
>
>> On 28 Jul 2022, at 5:21 pm, Chris Jones <jon...@hep.phy.cam.ac.uk> wrote:
>>
>>
>>
>>
>>> On 28 Jul 2022, at 5:17 pm, Mark Brethen <mark.bret...@gmail.com> wrote:
>>>
>>>
>>> ~ $ cd
>>> /opt/local/var/macports/build/_Users_marbre_ports_cad_CalculiX/CalculiX/work/CalculiX/cgx_2.18/src
>>> src $ sudo ack DrawCommandLine
>>> Password:
>>> cgx.c
>>> 5009: DrawCommandLine(keystroke, strlen(keystroke)+curshft);
>>> 5071: DrawCommandLine(keystroke, strlen(keystroke)+curshft);
>>> 5799: DrawCommandLine(0,0);
>>> 5803:void DrawCommandLine(char *string, int curpos)
>>> 5807: printf(" in DrawCommandLine\n");
>>> 5874: DrawCommandLine(0,0);
>>>
>>> cgx.h
>>> 588:void DrawCommandLine(char *string, int curpos);
>>>
>>> parser.c
>>> 85: DrawCommandLine(keystroke, strlen(keystroke)+*curshft);
>>>
>>>
>>> cgx.h has 'void DrawCommandLine(char *string, int curpos);’
>>>
>>> cgx.c has '#include <cgx.h>’
>>>
>>> parser.c has '#include <extUtil.h>’ only
>>>
>>> should I add '#include <cgx.h>’ to parser.c or add 'void
>>> DrawCommandLine(char *string, int curpos);’ to extUtil.h?
>>
>> Based on the above, no, but instead add it to parser.c
>
> Apologies, misread your reply. I would say yes to the first part.
>
>>>
>>> Mark Brethen
>>> mark.bret...@gmail.com <mailto:mark.bret...@gmail.com>
>>>
>>>
>>>
>>>> On Jul 27, 2022, at 8:41 PM, Joshua Root <j...@macports.org
>>>> <mailto:j...@macports.org>> wrote:
>>>>
>>>> There's only one -Wimplicit-function-declaration warning in the log, so it
>>>> doesn't look like there's a lot that needs fixing. Just say yes to
>>>> function prototypes. :)
>>>>
>>>> - Josh
