Well, that didn’t work.

Attachment: main.log
Description: Binary data


Attachment: Portfile
Description: Binary data

Attachment: patch-FbdReader-build.diff
Description: Binary data


Mark Brethen
mark.bret...@gmail.com



> On Aug 8, 2022, at 11:22 AM, Mark Brethen <mark.bret...@gmail.com> wrote:
> 
> The makefile only sets cc, not c++. If I remove -lstc++ from LIBS, then I 
> need to add it to the portfile using LDFLAGS. The Makefile uses LFLAGS, which 
> I don’t want to override. Should I add LDFLAGS to MAIN, like so:
> 
> $(MAIN): $(OBJS) 
>       $(CC) $(CFLAGS) $(INCLUDES) -o $(MAIN) $(OBJS) $(LFLAGS) $(LIBS) 
> $(LDFLAGS)
> 
> <Makefile>
> 
> 
> 
> 
> 
> Mark Brethen
> mark.bret...@gmail.com
> 
> 
> 
>> On Aug 8, 2022, at 11:10 AM, Joshua Root <j...@macports.org> wrote:
>> 
>> That's a completely different thing. The language standard is selected by 
>> -std, the stdlib implementation is selected by -stdlib, and linking to a 
>> stdlib directly (as -lstdc++ does) is usually a bug since the C++ compiler 
>> will implicitly add the appropriate stdlib when linking.
>> 
>> - Josh
>> 
>> On 2022-8-9 01:16 , Mark Brethen wrote:
>>> There is also -lstdc++, I thought those should be set in the Portfile. 
>>> Doesn’t macports-clang have its own standard?
>>> Mark Brethen
>>> mark.bret...@gmail.com <mailto:mark.bret...@gmail.com>
>>>> On Aug 7, 2022, at 7:22 PM, Ryan Schmidt <ryandes...@macports.org 
>>>> <mailto:ryandes...@macports.org>> wrote:
>>>> 
>>>> In fact, the Makefile already had -std=c++11, but your patchfile removed 
>>>> it. So don't remove it.
>> 
> 

Reply via email to