Hi,
as you thought, it is specific ASM stuff, so the typos are relative to
a precise architecture only,
On 2018-11-14 20:55:58 +0100 Ryan Schmidt <ryandes...@macports.org>
wrote:
On Nov 14, 2018, at 11:17, Riccardo Mottola wrote:
I wonder if this will cause issues on my 10.5 at the next upgrade,
since it
is 32bit form me.. I'll see.
zstd and tiff built successfully on our 10.5 PowerPC builder. The
problem may
be specific to 32-bit Intel, or it may be specific to Snow Leopard.
the previous patch was incomplete! Get this one... not just a
backport, I had to fix the ASM stuff!
I rock! Late in the night.. but this fixes 32bit intel.
Riccardo
<zstd-backport-fix-asm.patch>
--- lib/common/cpu.h 2018-03-27 00:19:34.000000000 +0200
+++ /Users/multix/cpu.h 2018-11-16 01:39:06.000000000 +0100
@@ -72,15 +72,14 @@
"cpuid\n\t"
"popl %%ebx\n\t"
: "=a"(f1a), "=c"(f1c), "=d"(f1d)
- : "a"(1)
- :);
+ : "a"(1));
}
if (n >= 7) {
__asm__(
"pushl %%ebx\n\t"
"cpuid\n\t"
- "movl %%ebx, %%eax\n\r"
- "popl %%ebx"
+ "movl %%ebx, %%eax\n\t"
+ "popl %%ebx\n\t"
: "=a"(f7b), "=c"(f7c)
: "a"(7), "c"(0)
: "edx");
