-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
Guillaume Pujol wrote: > 2007/3/17, Nicolas Boichat <[EMAIL PROTECTED]>: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> Guillaume Pujol wrote: >>> Hi, >>> >>> Attached to this mail you'll can find clean mactel patches for linux >>> kernel 2.6.20. >>> They apply against linux 2.6.20 + gentoo patchset + suspend2 without >>> offset nor fuzz (should apply to unpatched official kernel as well). >> Ok cool. Personally, when I did this job, I edited the patchfiles >> manually... Then it was easier for me to do a diff between the files, >> and check I didn't remove a part of the patch, or modify something... >> With your patchset it's hard for me to compare... > > Actually I did almost all modifications manually directly to the > patchfiles. It's not really what I see when I run a simple diff between the last SVN and your patchset, there are a huge amount of differences. > I had an hard time tracking and fixing all tab/spaces > mixings :). Just don't fix anything... It makes huge patches, and you lose track of the essential modifications... It's there are spaces, ok, it's bad, but leave them there. (in the kernel, you should only have tabs) > Apart from that and usbhid.patch, I did not change > anything in the code. Ok. >>> Also: >>> - rewritten usbhid.patch which was partly applied to official 2.6.20, >>> and added HID_QUIRK_IGNORE_MOUSE everywhere it was useful. >> Just beware of this in include/linux/hid.h: >> +#define HID_QUIRK_IGNORE_MOUSE 0x00010000 >> #define HID_QUIRK_BAD_RELATIVE_KEYS 0x00010000 >> >> These two constants should have a different values. > You are right, but this is the value figuring in the original > patchfile in mactel SVN. Maybe you'd like to change this value to > 0x00020000 like in upstream 2.6.21 ? Yes. >>> - removed a part of applesmc.patch which was redundant with coretemp.patch >> Which part exactly? I cannot see what you changed because you changed >> all the tabs in spaces... Also I don't think there is anything in >> applesmc redundant with coretemp... > > Oops sorry nervermind... I just checked again after a fresh checkout > and obviously there is nothing redundant. I guess it was the result of > a wrong manipulation on my local repo :| Ok. >> Thanks, > Thanks to you, >> Best regards, >> > > P.S: also I just checked and these patches apply just fine against > linux-2.6.20.3 straight from kernel.org. Ok cool to hear it. Best regards, Nicolas -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF/S9701ajQnpJXgERAvNDAJ9QHke3mIKRZ3rj1kPICrlKGeryZgCfXYEq l9RLNh25Kh9P4VyQHkfgSuQ= =vJLp -----END PGP SIGNATURE----- ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Mactel-linux-devel mailing list Mactel-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mactel-linux-devel
