Hi Marius, I've still not received a reply to this, so I'm presuming I'm bothering the wrong person, (or something is going wrong with my email), so I'll try CCing maemo-developers in the hope that someone can point me in the right direction to get this reviewed/integrated.
Thanks, Robin --- Begin forwarded message from Robin Burchell --- From: Robin Burchell <virot...@viroteck.net> To: Marius Vollmer <marius.voll...@nokia.com> Date: Thu, 01 Jul 2010 01:15:31 +0100 Subject: Fwd: libgq Hi Marius, Wondering whether you got the mail, forwarded below? Regards, -- Robin Burchell http://rburchell.com ---------- Forwarded message ---------- From: Robin Burchell <virot...@viroteck.net> Date: Wed, Jun 16, 2010 at 1:43 AM Subject: Re: libgq To: Marius Vollmer <marius.voll...@nokia.com> On Fri, Jun 4, 2010 at 4:23 PM, Marius Vollmer <marius.voll...@nokia.com> wrote: > ext Robin Burchell <virot...@viroteck.net> writes: > >> Sorry to pester you again so soon, but I have a possible addition to >> libgq. If you are interested, I can arrange a MR through Gitorious. > > Yes, sounds great! Hi Marius, I've created three MRs at http://maemo.gitorious.org/maemo-af/libgq/merge_requests Two of the issues we've discussed: better documentation that GConfItem is supposed to be long lived, and a class to get/set items directly (with appropriate warnings in documentation). Feedback on the second MR in particular is welcome. The third MR is a minor typo fix basically. I'd also like to deprecate GConfItem::set() in favour of Qt-izing the API a little: bool GConfItem::setValue(const QVariant &val) Two changes from ::set(): - it returns whether or not the key change is successful - it follows Qt's naming convention better (value() to get, setValue() to set). If you like this idea, I'll submit a MR for it. I'd also subsequently wish to update MR #2 to return success/failure of key setting, for consistency. Let me know your thoughts, and I hope I don't seem to be pestering you about something so trivial. :) --- End forwarded message --- -- Robin Burchell http://rburchell.com _______________________________________________ maemo-developers mailing list maemo-developers@maemo.org https://lists.maemo.org/mailman/listinfo/maemo-developers
