On 27 May 2011 13:35, Michael Scherer <m...@zarb.org> wrote: >> > Modified: mgaonline/trunk/mgaonline.pm >> > =================================================================== >> > --- mgaonline/trunk/mgaonline.pm 2011-05-27 09:01:31 UTC (rev 1554) >> > +++ mgaonline/trunk/mgaonline.pm 2011-05-27 10:03:00 UTC (rev 1555) >> > @@ -162,7 +162,7 @@ >> > >> > >> > sub clean_confdir() { >> > - my $confdir = '/root/.MdkOnline'; >> > + my $confdir = '/root/.MgaOnline'; >> > system "/bin/rm", "-f", "$confdir/*log.bz2", "$confdir/*log.bz2.uue", >> > "$confdir/*.dif $confdir/rpm_qa_installed_before", >> > "$confdir/rpm_qa_installed_after"; >> > } > > system rm -f, am I the only one to find that's ugly ?
That's code bound to be removed anyway, it's obsolete for quite a couple releases but it's not the moment for doing cleaning-that-have-no-impact-I-assure-upi. Though I wonder why the initial coder didn't reuse MDK::Common It's basically obsolete since march 2007 when I switch mdkonline from poor server side update computations to locally using urpmi core to compute updates which is both more scalable and quite a lot more accurate (taking into account provides, obsoletes, skip.list, actual packages avaibility on used mirrors and the like...). the server was using its own basic algorithm based only on packages list