Am 09.09.2011 20:57, schrieb John Balcaen:
2011/9/9 Mageia Team<buildsystem-dae...@mageia.org>:
Name : kphotoalbum Relocations: (not relocatable)
Version : 0 Vendor: Mageia.Org
Release : 1.mga2 Build Date: Fri Sep 9 19:07:38 2011
Install Date: (not installed) Build Host: jonund
Group : Graphics Source RPM: (none)
Size : 37771417 License: GPLv2+
Signature : (none)
Packager : Mageia Team<http://www.mageia.org>
URL : http://www.kphotoalbum.org/
Summary : Photo album manager
Description :
KPhotoAlbum supports all the normal image formats including
raw formats produced by most digital cameras and scanners
(using dcraw to do the decoding).
It is also possible to use the thumbnails embedded in raw
images (that are usually of decent size and quality) for
fast viewing so there is no need to decode the whole raw image.
Version GIT 61a16c1
matteo<matteo> 0-1.mga2:
+ Revision: 141909
- cleaned spec
- imported package kphotoalbum
You should clean a little bit more this package :
You can use libexiv-devel as BR instead of an arch conditionnal BR
(also now the best solution to match our policy would be to use
pkgconfig(exiv2)
After marble-devel is pulling kdelibs4-devel which is pulling
qt4-devel& kde4-macros (which is pulling cmake)
So you can have only 2 BR on this package marble-devel and pkgconfig(exiv2).
%clean section& %defattr() are required anymore so you can safely remove them.
in the %files list you can also use more kde4 macros
like %_kde_applicationsdir or %_kde_appsdir
Regarding the %mkrel if you're using a git tarball it could be nice to
have it announced in the file name
something for release like %mkrel -c git %git should do the trick
Interesting. What does %mkrel -c git do?
Isn't there a problem when using git commit hashes as they are random,
unsorted, and shouldn't be used in a version comparison?
See f.ex. this thread: http://lists.mandriva.com/cooker/2011-03/msg00009.php
Although i didn't look at the SPEC at all ...
Also the last version of kphotoalbum is 4.1.1 so the version should not be 0
Thks for importing another kde app :)
Regards,
