'Twas brillig, and Anssi Hannula at 06/03/12 18:34 did gyre and gimble: > Hi! > > As per https://bugzilla.gnome.org/show_bug.cgi?id=657385 > gtk_menu_popup_for_device() has been renamed to gtk_menu_popup() in > introspection, causing at least Menu.popup() in python-gi to break. > > Ubuntu has reverted it: > https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/923171 > > Attached are alternative one-liner patches to either revert the API > break in Gtk+3.0 (dont_rename_annotation.patch, from Ubuntu), or to > adapt python-gobject3 to the API change > (python-gi-adapt-for-gnome657385.patch, written by me).
My gut feeling would be that your patch is the better and more upstream compatible direction here. I suspect if the Ubuntu approach is used, we'll also have to fix Vala stuff in the future too (which will very likely follow the upstream direction). Don't know what else would use the introspection stuff. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/