On Thu, Feb 14, 2013 at 2:22 PM, <r...@mageia.org> wrote: > ** > Revision 7324 Author colin Date 2013-02-14 15:22:44 +0100 (Thu, 14 Feb > 2013) Log Message > > (call_blkid) always bypass blkid cache > > This reverts the use of the blkid cache. > > This cache is a broken concept and should not be used. It's only > intended to be used for LABEL/UUID conversion. > > Please add a comment in the code :)
> > From the upstream maintainer: > <kzak> coling: -p provides more information, the cache is designed for > LABEL/UUID conversion -- and the goal is to avoid the cache if possible > (it's mostly for backward compatibility). The ideal solution is to read > the information from udev DB. > <kzak> coling: man blkid (at least the latest version contains some hint > about this issue) > <kzak> coling: I'd like to learn people to use lsblk -- it's designed > more friendly for end-users as well as for scripts and it reads info > from udev, libblkid is only fallback here. > > Longer term we should kill off the use of blkid and perhaps move to > lsblk or some perl-udev (if such a thing exists) usage instead: > > <kay> coling: avoid the blkid cache, it is a completely broken idea > <kay> kzak: you should really kill that thing :) > <kzak> kay: I'd like to kill blkid at all and keep it as "to test the > library" binary... > <kay> kzak: tools with options like that talk for their sanity > themselves :) " -g Perform a garbage collection pass on the blkid > cache to remove devices which no longer exist." > <kay> kzak: it's just silly, really silly to ever do that :) > <kay> kzak: yeah, sounds fine to let blkid and its cache die in the long > run > <kzak> lsblk is maintainable and extendable -- fix blkid(8) is > impossible to fix... > > This reverts r6891. > > Modified Paths > > - > drakx/trunk/perl-install/NEWS<#13cd91629257f7c0_drakxtrunkperlinstallNEWS> > - > drakx/trunk/perl-install/fs/type.pm<#13cd91629257f7c0_drakxtrunkperlinstallfstypepm> > - > drakx/trunk/perl-install/install/NEWS<#13cd91629257f7c0_drakxtrunkperlinstallinstallNEWS> > > Modified: drakx/trunk/perl-install/NEWS > =================================================================== > --- drakx/trunk/perl-install/NEWS 2013-02-14 01:39:37 UTC (rev 7323) > +++ drakx/trunk/perl-install/NEWS 2013-02-14 14:22:44 UTC (rev 7324) > @@ -1,3 +1,5 @@ > +- always bypass blkid cache (the cache only includes a subset of the data we > need) > + > Version 15.19 - 16 January 2013 > > - update translations > Modified: drakx/trunk/perl-install/fs/type.pm > =================================================================== > --- drakx/trunk/perl-install/fs/type.pm 2013-02-14 01:39:37 UTC (rev > 7323) > +++ drakx/trunk/perl-install/fs/type.pm 2013-02-14 14:22:44 UTC (rev > 7324) > @@ -273,7 +273,7 @@ > > my %h = map { > if_(/(.*?)=(.*)/, $1 => $2); > - } run_program::get_stdout_raw({ timeout => 30 }, 'blkid', '2>', > '/dev/null', '-o', 'udev', devices::make($part->{device})); > + } run_program::get_stdout_raw({ timeout => 30 }, 'blkid', '2>', > '/dev/null', '-o', 'udev', '-p', devices::make($part->{device})); > > \%h; > } > Modified: drakx/trunk/perl-install/install/NEWS > =================================================================== > --- drakx/trunk/perl-install/install/NEWS 2013-02-14 01:39:37 UTC (rev > 7323) > +++ drakx/trunk/perl-install/install/NEWS 2013-02-14 14:22:44 UTC (rev > 7324) > @@ -1,3 +1,5 @@ > +- always bypass blkid cache (the cache only includes a subset of the data we > need) > + > Version 15.20 - 21 January 2013 > > - use modprobe instead of insmod (mga#8676) > > >