Op donderdag 14 maart 2013 19:47:36 schreef Thierry Vignaud: > On 13 March 2013 20:52, <r...@mageia.org> wrote: > > Revision 7542 Author alien Date 2013-03-13 20:52:07 +0100 (Wed, 13 Mar > > 2013) > > > > Log Message > > > > - fix loading modules with "-" in their names (mga#9242) > > - add an easy buildtarget for testing > > A couple remarks: > - next time do a commit a time (first your change, then bumping version)
ah, ok, is there a reason for this (to have separate a change and then a version bump)? now that you mention this, i think i've seen you say this to thomas before... it would've been nice to have had some documentation regarding these things... > - please revert your dist-svn-test; > when one wants to test, either he commits in git-svn or he locally runs > "make" well, it would've been nicer if you have said so before (or documented it someplace), i spent more than 4 hours figuring out why my changes had no effect... but sure, i'll revert it. > I hope you tested several modules with both case? yes, i tried with several. and since the xen-netfront modules aren't autodetected for some reason (i'm trying to look into it), i had the opportunity to test alot with various modules. (also, i note that virtmanager telling to use e1000 or other model, it still uses the netfront one instead..) > > Modified Paths > > > > drakx/trunk/mdk-stage1/Makefile > > drakx/trunk/mdk-stage1/NEWS > > drakx/trunk/mdk-stage1/modules.c > > > > Modified: drakx/trunk/mdk-stage1/Makefile > > =================================================================== > > --- drakx/trunk/mdk-stage1/Makefile 2013-03-12 19:12:12 UTC (rev 7541) > > +++ drakx/trunk/mdk-stage1/Makefile 2013-03-13 19:52:07 UTC (rev 7542) > > @@ -15,7 +15,7 @@ > > > > # along with this program; if not, write to the Free Software > > # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > > > -VERSION=1.74.1 > > +VERSION=1.75 > > > > PRODUCT=drakx-installer-binaries > > > > # > > > > @@ -217,6 +217,14 @@ > > > > fi; > > > > $(info $(PRODUCT)-$(VERSION).tar.xz is ready) > > > > +dist-svn-test: > > + mkdir -p $(PRODUCT)-$(VERSION) > > + svn export -q . $(PRODUCT)-$(VERSION)/mdk-stage1 > > + svn export -q ../kernel $(PRODUCT)-$(VERSION)/kernel > > + cp ../Makefile.config $(PRODUCT)-$(VERSION)/ > > + tar cfa $(PRODUCT)-$(VERSION).tar.xz $(PRODUCT)-$(VERSION) > > + rm -rf $(PRODUCT)-$(VERSION) > > + > > > > dist-svn: > > mkdir -p $(PRODUCT)-$(VERSION) > > svn export -q -rBASE . $(PRODUCT)-$(VERSION)/mdk-stage1