On 29/03/13 00:19, PhilippeDidier wrote:
Barry Jackson a écrit :
Thanks Philippe,
I have committed your changes (but somewhat shrunk ;) - please check it
over and I will submit, as the group change is quite important.
Cheers,
Barry
Hi Barry
Sorry for being so late to answer
I tested the spec you commited
built ardour3-3.0.2
installed it
tested it : the symlinks are wrong ?!!!
Reused my own spec file
rebuild installed : the symlinks work ?!!!
Indeed :
because of an artefact I couldn't see that the symlinks that I created
were wrong (leading to BUILDROOT/ardour3-3.0-1.mga2.i386 that had not
been deleted ... the links showed the icons )
I know why now !
Anyway there's a little typo in yours (ardour_icon_${i}x.png instead of
ardour_icon_${i}px.png)
Here is a new svndiff with corrected symlinks and the typo corrected
Better tested this time ;-)
I am sure the symlinks are correct (they needed a relative path !!!!)
I tested them several ways : they are all OK
I think you may commit and submit now
Regards
Philippe
Yep - sorry about the typo and I should have spotted the symlink error.
Fixed in svn - please double check ;)
BTW there was no need to use all the ../../ just removing %{buildroot}
on the target is enough.
