Fixed the actual print style sheet to work correctly.

File: theme/raw/static/style/print.css (fixed and attached)
File: theme/raw/templates/header/head.tpl (if somebody knows how to fix that 
part, it would be appreciated).

The problem is that the template code
(/theme/raw/templates/header/head.tpl) is trying to read the style sheet
from only the theme instead of raw and then the theme, if the theme has
a print style sheet.  I could not figure out how to fix that part, so I
only attached the print.css file.

If an end user wants to attach this patch, they will need to temporarily
add a hardcoded fixed to the head.tpl file:

Old code in head.tpl:
   <link rel="stylesheet" type="text/css" href="{theme_url 
filename='style/print.css'}" media="print">
New code in head.tpl:
    <link rel="stylesheet" type="text/css" 
href="http://localhost/portfolio/theme/raw/static/style/print.css"; 
media="print">

FYI: The print.css file was completely rewritten, so just copy it over,
don't try to patch it.  This file has not been extensively tested.
Tested only on Firefox (current version) using print-preview on a US
computer system.  Also, only the view, dashboard, collection, and
profile were tested.  Did not test the printing of other pages.

Related issues:
* What to do about navigation -- Do we need two classes, so the end user can 
choose if they want their page navigations (page views) to be included or not 
included)?
* print-page-breaks -- adding the class to the print.css file is done, but how 
does a user add this to their page?  Do we need to add a blocktype called 
"print-page-break"?
* Do we want to allow the user to add a print MLA at the end of a print page?


** Attachment added: "New print.css file"
   
https://bugs.launchpad.net/mahara/+bug/692769/+attachment/2532927/+files/print.css

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/692769

Title:
  Make sure that the print stylesheet still works

Status in Mahara ePortfolio:
  Triaged

Bug description:
  We should make sure that views have a working print stylesheet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/692769/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to