There are two options the function user_comments_allowed() needs to check: allowcomments and approvecomments.
if allowcomments of one access right is true, the user can put comments and if approvecomments of one access right is FALSE given the allowcomments is TRUE then the user can publish his/her comment without the approval of the owner. I think the function user_comments_allowed() is correct as it needs to check though all access rights for both "allowcomment" and "approvecomment" flags ** Changed in: mahara Status: In Progress => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/1095890 Title: allowcomments not respected properly Status in Mahara ePortfolio: Invalid Bug description: Not sure why, but the function user_comments_allowed (lib/view.php line 3872), seems to check through all the access rights for the "allowcomment" flag, which doesn't seem to be configurable from the web interface. If the page has allowcomments off, and one of the access rights allows comments, then comments are allowed. The particular access right i found it on was an "objectionable" type. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1095890/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp