Reviewed:  https://reviews.mahara.org/2076
Committed: 
http://gitorious.org/mahara/mahara/commit/45590e30ba11e21d5203ab46f06164972ce15e39
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:    master

commit 45590e30ba11e21d5203ab46f06164972ce15e39
Author: rlyon <rl...@paradise.net.nz>
Date:   Mon Apr 22 10:20:35 2013 +1200

Fix to allow decompression of zip files with subdirectories (Bug
#788882)

For zip decompression with subdirectories the folders are created first
then the files added later so needed to get any child subfolders to be added
to their correct parent folder.
Also needed to correctly check if folder existed to stop making extra
empty folders.

Change-Id: Ie6c5b8d130488914542a46cfcf355ee00785fb14
Signed-off-by: rlyon <rl...@paradise.net.nz>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/788882

Title:
  Extracting zip files causes multiple empty folders to appear

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  When I extract a zip file (attached) with multiple files in
  subdirectories, the outcome is that multiple empty folders are created,
  and some files are placed in the root directory instead of subfolders.

  There is also a log (also attached) which happens when the 2nd
  screenshot is displayed (extract-finished.png)

  There are a few screenshots attached.

  extract-start.png shows the files it plans to extract
  extract-finish.png shows the finish screen (there were also error logs
  for this step)

  extract-after.png (folder displayed directly after clicking "Continue")
  extract-fisrt-folder.png (first folder in that directory listing, empty
  (same with every folder except the 2nd (not always 2nd in subsequent
  tries :P))
  extract-in-second-folder.png (in the second folder, seems to have the
  files, but all the folders within are empty)
  extract-in-subfolder.png (showing emptyness of the subfolder, all are
  the same)
  extract-in-home-folder.png (more copys of empty folders (won't bother
  with screenshots, and also all the missing files from the subdirectories)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/788882/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to