To replicate:

1. Log in as a user
2. Go to the Account Settings page and tick the "Multiple journals" checkbox.
3. Create a second journal
4. Go back to the Account Settings page.

Expected result: The "Multiple journals" checkbox should not be editable.
Actual result: The "Multiple journals" checkbox can be unticked.

I'm able to replicate this in Chromium and Firefox. The checkbox is
marked readonly, but it's still checkable.

<input type="checkbox" class="checkbox" id="accountprefs_multipleblogs"
name="multipleblogs" tabindex="1" readonly="readonly"
checked="checked"/>

In Firefox, the checkbox looks grayed-out, but it can still be ticked
and unticked. In Chromium it looks perfectly normal.

Apparently, "readonly" does NOT prevent you from ticking or unticking a
checkbox, as that is considered "state" rather than "value". The
suggested solution is to mark it "disabled". This will prevent the
checkbox from sending ANY value through when the form is submitted,
however, so it should be combined with further logic in the form
submissions code to handle that. Or a hidden input field to pretend the
checkbox is actually sending something through. (Although of course we
should still do a server-side check of whether the user is allowed to
change this setting before processing any hidden input field's value.)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1237095

Title:
  Users can unset 'Multiple journals' option even having more than one

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Version: master
  Platform: all

  If an user have more than one journals, the option 'Multiple journals' in the 
account setting page is 'read-only'.
  When I unset it and save.
  Actual result: the option have been updated, and only one journal was shown
  Expected result: The option should not be changed

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1237095/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to