Reviewed: https://reviews.mahara.org/3191 Committed: http://gitorious.org/mahara/mahara/commit/afdae5c6e08ea6f0a8da9cc7117d8f0ef84e79bc Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch: 1.9_STABLE
commit afdae5c6e08ea6f0a8da9cc7117d8f0ef84e79bc Author: Aaron Wells <aar...@catalyst.net.nz> Date: Wed Apr 2 14:32:29 2014 +1300 Get rid of the obsolete and redundant get_mime_type() method Bug 1301096 Change-Id: I3d3f200da83ca94232c5da46c91211f7634b4a91 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1301096 Title: Eliminate redundant &obsolete get_mime_type() function Status in Mahara ePortfolio: Fix Committed Bug description: In htdocs/lib/file.php, right above file_mime_type(), there's another method called get_mime_type() that uses the Unix "file" utility. It's only used one place in the code, which is in an upgrade to the file artefact type from 2008. I'd like to eliminate this redundant function to prevent other people from accidentally using it. Since the function is only used one place, we can make the upgrade script continue to work by just copying the whole text of the function inline into the upgrade.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1301096/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
