Reviewed: https://reviews.mahara.org/3726 Committed: http://gitorious.org/mahara/mahara/commit/3fb65b89c02e09f3947787fb28790de92a687ee3 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 3fb65b89c02e09f3947787fb28790de92a687ee3 Author: Robert Lyon <robe...@catalyst.net.nz> Date: Fri Sep 26 10:09:59 2014 +1200 Allowing the mygroups to paginate when cleanurls on (Bug #1374184) To test: 1) Set up a few users all being members of many groups (I tested with 17 groups) 2) for each user edit their profile page and edit the 'My groups' block and set the 'Maximum number of groups to display' value to something less than the number of groups available 3) Then test if you can paginate on both logged-in users profile page and other users profile pages Test for both when clean urls are on and off Change-Id: I26a247fc4a692b2e82b6c235d41172ff35fadeac Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1374184 Title: My groups block pagination fails when clean urls are in play Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Bug description: Now that we can paginate the list of groups on the my groups block there is a problem when cleanurls are in place. The pagination relies on scraping the url for the parameters to pass via ajax to fetch the subsequent pages. but with clean urls the user id is not in the url so fails to go to next page. To fix: 1) need to add a js variable to the page containing the user id number for the user whose profile page we are trying to view. 2) need to get the pagination js to add this id to the pagination params Will mark this as a regression because before one could see all their groups in a long list - now they can only see the first page To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1374184/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp