Reviewed: https://reviews.mahara.org/4640 Committed: http://gitorious.org/mahara/mahara/commit/cc0aa2732a16c8e8d4db55218cef32c5172b15c7 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 1.10_STABLE
commit cc0aa2732a16c8e8d4db55218cef32c5172b15c7 Author: Robert Lyon <robe...@catalyst.net.nz> Date: Thu Apr 16 10:54:23 2015 +1200 Allowing the skin underline setting to work (Bug #1429871) Do correct string/variable comparison Change-Id: I98c5c1360891699e439108789b2015d7587222ca Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin > Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin->viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
