Reviewed: https://reviews.mahara.org/5686 Committed: https://git.mahara.org/mahara/mahara/commit/acb253747481e2dc6db7b7ca3adb554b822f1930 Submitter: Robert Lyon ([email protected]) Branch: 15.10_STABLE
commit acb253747481e2dc6db7b7ca3adb554b822f1930 Author: Robert Lyon <[email protected]> Date: Fri Oct 30 12:26:48 2015 +1300 Bug 1511536: problem with deleting blocks when edit page first loads The problem is due to the scope of the blockinstanceId variable being outside of the click handler function, which inadvertently makes it into a sort of static variable shared by all of the delete buttons. So the solution is to use a locally-scoped blockinstanceId button inside the click handler method. Change-Id: I3e8ffac31cc869c545e85c5f53c3e710e2e71243 Signed-off-by: Robert Lyon <[email protected]> Signed-off-by: Aaron Wells <[email protected]> (cherry picked from commit 52770f8baf2297d9cbf5506e2696b346fae8f419) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1511536 Title: Deleting blocks from page fails in some cases in 15.10 Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: The is an odd bug where the block being deleted doesn't remove itself from the edit screen. so when you try to delete it again you get an error message that the block doesn't exist any more. To replicate: Make a page and add some blocks to the page - preferably 3 or more (any type) Go to display page Go back to edit page and delete the blocks - the first will delete fine but then next ones will not disappear However if each block is edited and then deleted they are removed fine. So this sounds like there is a problem with initial setup of the js relating to the delete buttons but not when the buttons are rewritten after config changes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1511536/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
