Hi Robert,

Thanks for the patch. We've had a request from one of our clients to
improve the error message that's thrown when adding a group through the
csv upload and the group name is already in use.

Maybe something like:

 throw new UserException('group_create: The supplied shortname \'' .
                        $data['shortname'] . '\' is already in use. This 
shortname \'' .
                        $shortname . '\' is available.');

Instead of:

throw new UserException('group_create: problem with supplied shortname '
. $data['shortname'] . ' not matching allowed shortname ' . $shortname);


I'll submit a patch.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597133

Title:
  Add institution shortname to manually created groups

Status in Mahara:
  Fix Committed

Bug description:
  In bug ​#826649 new functionality is introduced to Mahara so that all
  groups can have group shortnames and thus be updated via CSV files.
  The group shortname was not enough to add though as an institution
  shortname is needed as well.

  Currently, groups created by CSV have to be associated with an institution so 
that:
  1. Institution admins only create groups within their realm of administrative 
permissions.
  2. Institution admins can't bulk add users from other institutions to their 
group to prevent issues.
  3. web services calls can be made in the future to create groups and allow 
institutions to manage that.

  The problem though is that the current screen "Administer groups"
  doesn't say which groups belong to which institution making it
  difficult for a site administrator to see which groups can be updated
  by institution admins and which ones can't because all have a group
  shortname.

  The way forward is the following:

  1. Add the institution shortname "mahara" to all manually created groups so 
that there are no error messages.
  2. Implement an institution selector (like we have on Administration -> Users 
-> User search for example) so that site admins can filter the groups by 
institution to quickly download the CSV file with all the groups an institution 
can administer as well as group membership (currently in review).

  Additional wishlist items are separately reported and don't form part
  of this fix:

  A. Make "Administer groups" available to institution administrators so
  that they can see all the groups they can administer, similarly to the
  "User search" page. Bug #1597134

  B. Allow the institution association to be changed so that institution
  admins could take over a manually created group. Bug #1597136

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597133/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to