Reviewed: https://reviews.mahara.org/6955 Committed: https://git.mahara.org/mahara/mahara/commit/ff2bee5b291082bbb973b4c46b43d3a7c92b45d4 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 16.10_STABLE
commit ff2bee5b291082bbb973b4c46b43d3a7c92b45d4 Author: Robert Lyon <robe...@catalyst.net.nz> Date: Fri Sep 2 15:17:47 2016 +1200 Bug 1620119: Fix for the brokenness in annotation feedback list Things fixed here: 1) The floating in space button for first feedback entry 2) The poor alignment for the annotation edit + delete buttons combo 3) Allowing an admin to delete their own feedback on their own annotation behatnotneeded Change-Id: I829280d89ca0020b2895120124ac59507285bf71 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> (cherry picked from commit 5f70a878fc0fc0ba2a87bd6b71bd4f752ac00e2f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1620119 Title: Annotation feedback edit/delete buttons not styled correctly Status in Mahara: Fix Committed Bug description: When comparing the edit/delete buttons on annotation feedback they are different to the same set of buttons on comments, when comments are a block on the page rather than at foot of the page. See attached screenshot The issues I see are: 1) The first annotation feedback's edit button is floating in space rather than being anchored to a line 2) When we have both edit and delete buttons they are not horizontally next to each other. Also another issue is an admin can't delete their own feedback from their own page's annotation block. In artefact/annotation/lib.php there is the following code: else if (($candelete || $item->isauthor) && !$is_export_preview && !$isadminfeedback) { // If the auther was admin/staff and not the owner of the annotation, // the feedback can't be deleted. But it is not correct when the owner is also an administrator. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1620119/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
