Reviewed: https://reviews.mahara.org/7025 Committed: https://git.mahara.org/mahara/mahara/commit/58badae96b1a53a8b9322ff1c7c91c5ec4a16e04 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 16.10_STABLE
commit 58badae96b1a53a8b9322ff1c7c91c5ec4a16e04 Author: Robert Lyon <robe...@catalyst.net.nz> Date: Wed Sep 14 13:48:17 2016 +1200 Bug 1623282: property of non-object error for old annotations When the old annotations have feedback on them behatnotneeded Change-Id: I1325ebf9d3067065730442b81c885d5b7178c777 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> (cherry picked from commit 1adfbdc6ecee0accc0375b96102e0e9dfe09be07) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1623282 Title: Existing annotations throw warning due to missing evidence Status in Mahara: Fix Committed Bug description: As we added annotation plugin a while back those annotations do not have an evidence value set for them. We need to take that into account when rendering their feedback Call stack (most recent first): log_message("Trying to get property of non-object", 8, true, true, "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278) at /var/www/html/mahara/htdocs/lib/errors.php:513 error(8, "Trying to get property of non-object", "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278, array(size 11)) at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1278 ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation), object(View), null, "108", false, "0") at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1132 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1623282/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp