Reviewed: https://reviews.mahara.org/7172 Committed: https://git.mahara.org/mahara/mahara/commit/22c474e378d639cc7d96ad2e5b0a2e146a8efccd Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 16.10_STABLE
commit 22c474e378d639cc7d96ad2e5b0a2e146a8efccd Author: Robert Lyon <robe...@catalyst.net.nz> Date: Mon Sep 26 15:18:41 2016 +1300 Bug 1627545: Skip check for valid json if no file uploaded On the matrix upload page behatnotneeded Change-Id: Iae1989b5dd8136e01766ee24a4538bd50b5a1320 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> (cherry picked from commit a3080fe2fdd02d704d61e84fea57588e208f3d88) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1627545 Title: Warning message is displayed when no framework is uploaded and saved Status in Mahara: Fix Committed Bug description: Version 16.10 Browser : FF Functionality: Smart Evidence [WAR] 4a (module/framework/lib.php:72) file_get_contents(): Filename cannot be empty Call stack (most recent first): log_message("file_get_contents(): Filename cannot be empty", 8, true, true, "/var/www/html/mahara/htdocs/module/framework/lib.p...", 72) at /var/www/html/mahara/htdocs/lib/errors.php:513 error(2, "file_get_contents(): Filename cannot be empty", "/var/www/html/mahara/htdocs/module/framework/lib.p...", 72, array(size 2)) at Unknown:0 file_get_contents("") at /var/www/html/mahara/htdocs/module/framework/lib.php:72 PluginModuleFramework::matrix_is_valid_json(null) at /var/www/html/mahara/htdocs/module/framework/lib.php:144 PluginModuleFramework::validate_config_options(object(Pieform), array(size 6)) at Unknown:0 call_user_func_array(array(size 2), array(size 2)) at /var/www/html/mahara/htdocs/lib/mahara.php:1730 call_static_method("PluginModuleFramework", "validate_config_options", object(Pieform), array(size 6)) at /var/www/html/mahara/htdocs/admin/extensions/pluginconfig.php:120 pluginconfig_validate(object(Pieform), array(size 6)) at Unknown:0 call_user_func_array("pluginconfig_validate", array(size 2)) at /var/www/html/mahara/htdocs/lib/pieforms/pieform.php:1449 Pieform->validate(array(size 6)) at /var/www/html/mahara/htdocs/lib/pieforms/pieform.php:521 Pieform->__construct(array(size 9)) at /var/www/html/mahara/htdocs/lib/pieforms/pieform.php:164 Pieform::process(array(size 9)) at /var/www/html/mahara/htdocs/lib/mahara.php:4764 pieform(array(size 9)) at /var/www/html/mahara/htdocs/admin/extensions/pluginconfig.php:81 Steps to reproduce: 1) Login as admin user 2) Navigate to Administration>Extensions>Smart Evidence 3) Click on Add framework 4) Without attaching any file click on save button 5) Now again click on smart evidence hyperlink Expected result: It should go back to smart evidence page where we can add new framework Actual result: A warning error message is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1627545/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
